1

Closed

Patch to Util.cs

description

C:\src\XmlVisualizer\XmlVisualizer

file attachments

Closed Nov 18, 2008 at 1:07 PM by larshove

comments

zippy1981 wrote Nov 18, 2008 at 3:20 AM

I mean to say in the comment that I add a Trace message to the catch block of DeleteFile(), put using blocks around some IDisosable objects, and made the class static (since all the member already were.)

zippy1981 wrote Nov 18, 2008 at 4:02 AM

More updates.

wrote Nov 18, 2008 at 4:02 AM

larshove wrote Nov 18, 2008 at 10:26 AM

You got some nice changes. I'll implement most of them in the next release.

wrote Nov 18, 2008 at 12:59 PM

wrote Nov 18, 2008 at 1:07 PM

zippy1981 wrote Nov 19, 2008 at 7:02 PM

Lars,

Out of curiosity, why did you not add my trace messages to your empty catch blocks? Would you prefer System.Diagnostics.Debug calls? That should cause the messages to just go to the Visual Studio output window.

Conditional compilation could be used if you feel the end user would not want to see these messages, but you would find use in debugging them.

larshove wrote Nov 20, 2008 at 7:06 AM

The only reason why I made the empty catch block was to bypass errors when the visualizer tries to remove a file that could already have been removed by the user.

To remove unnecessary overhead I left out debugging information on that catch block. I have removed the try/catch block now, and replaced it with a File.Exists instead. That's probably better :)

wrote Feb 14, 2013 at 2:59 AM

wrote May 16, 2013 at 8:47 AM